This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fb1adcde22c: [clangd] Log directory when a CDB is loaded
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73628/new/
kadircet updated this revision to Diff 241388.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73628/new/
https://reviews.llvm.org/D73628
Files:
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62284 tests passed, 0 failed
and 831 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:122
+if (Entry.CDB)
+ vlog("Loaded CDB from {0}", Dir);
}
consider
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Fixes https://github.com/clangd/clangd/issues/268
Repository:
rG LLVM Github Monorepo
