This revision was automatically updated to reflect the committed changes.
Closed by commit rGc53cb2bdc78e: [Clang][Bundler] Reduce fat object size
(authored by sdmitriev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73642/new/
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73642/new/
https://reviews.llvm.org/D73642
___
cfe-commits mailing list
sdmitriev added a comment.
@ABataev, do you have any additional comments?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73642/new/
https://reviews.llvm.org/D73642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:378
+ // Creates temporary file with given contents.
+ Expected Create(Optional> Contents) {
+SmallString<128u> File;
sdmitriev updated this revision to Diff 241278.
sdmitriev added a comment.
Addressed review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73642/new/
https://reviews.llvm.org/D73642
Files:
clang/test/Driver/clang-offload-bundler.c
ABataev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:371
+// object destruction.
+struct TempFileList {
+ ~TempFileList() {
If you have `private` members, it should be a class. Also, seems to me it is a
RAII
sdmitriev updated this revision to Diff 241269.
sdmitriev added a comment.
Addressed review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73642/new/
https://reviews.llvm.org/D73642
Files:
clang/test/Driver/clang-offload-bundler.c
ABataev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:493-518
+// Temporary files that need to be removed.
+struct TempFileList : public SmallVector, 2u> {
+ ~TempFileList() {
+for (const auto : *this)
+
sdmitriev created this revision.
sdmitriev added a reviewer: ABataev.
Herald added a reviewer: alexshap.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fat object size has significantly increased after D65819
