merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed
and 838 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9c903d0373ff: [clangd][Hover] Handle uninstantiated default
args (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73723/new/
kadircet updated this revision to Diff 241707.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73723/new/
https://reviews.llvm.org/D73723
Files:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tools-extra/clangd/Hover.cpp:276
+// we only print the expression.
+if (PVD->hasDefaultArg() && !PVD->hasUnparsedDefaultArg()) {
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed
and 838 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
kadircet created this revision.
kadircet added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Default args might exist but be unparsed or uninstantiated.
getDefaultArg asserts on those. This patch
