[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

This revision was automatically updated to reflect the committed changes. Closed by commit rG63959803702c: [Driver] Move GCC multilib/multiarch paths support from Linux.cpp to Gnu.cpp (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. @MaskRay : Samuel Thibault CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay added a comment. In D73845#2000455 , @sthibaul wrote: > Thanks! I don't have commit access, could somebody commit this for me? Can you provide your `name `? I need this information to run `git c --amend --author=` CHANGES SINCE LAST ACTION

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. Thanks! I don't have commit access, could somebody commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. ping @phosek ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! You may need to wait for @phosek to confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul updated this revision to Diff 256436. sthibaul marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul marked 2 inline comments as done. sthibaul added a comment. In D73845#1971282 , @MaskRay wrote: > Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have > you made any adjustment? No, it's really pure code move (and the

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2694 + +void Generic_GCC::AddGCCMultilibPaths(const Driver , + const std::string , The class already has `GCC` in the name, so there's no need to

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay added a comment. Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have you made any adjustment? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. Hello, any news on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. > I however didn't find how to specify in phabricator a dependency between the > two diffs, is that supported in phabricator? Ah, it can be set as child revision after creating the diff, done so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul updated this revision to Diff 243378. sthibaul retitled this revision from "[Gnu toolchain] Look at standard GCC multilib/multiarch paths by default" to "[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu". CHANGES SINCE LAST ACTION

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul marked an inline comment as done. sthibaul added a comment. >> I feel like in this specific case it may be worth splitting this into two >> patches: > > Alright, doing so. It is now on https://reviews.llvm.org/D74282 I however didn't find how to specify in phabricator a dependency