[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall marked an inline comment as done. sammccall added a comment. In D73873#1857042 , @thakis wrote: > I agree it's a bit strange. The linux bot didn't recover after the revert > either, so something's amiss. > > My Win bot has been hanging since

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

thakis added a comment. I agree it's a bit strange. The linux bot didn't recover after the revert either, so something's amiss. My Win bot has been hanging since this landed and I just CRD'd in and it's hanging in check-clangd and there are tens of ClangdTests processes hanging around and

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall added a comment. In D73873#1856880 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/9296/step_9.txt Thanks, I've reverted to take a look. It's weird though: - don't see this on any lab buildbots or locally - the lit test

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/9296/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73873/new/ https://reviews.llvm.org/D73873 ___ cfe-commits

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG92570718a86c: [clangd] Mechanism to make update debounce responsive to rebuild speed. (authored by sammccall). Changed prior to commit:

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, a few nits. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:249 + llvm::SmallVector + RebuildTimes; /* GUARDED_BY(Mutex) */ /// File that ASTWorker

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62406 tests passed, 0 failed and 839 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Currently we delay AST rebuilds by 500ms after each edit, to wait for further