[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG7128aace600f: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

simon_tatham added a comment. I wonder if it's worth temporarily redefining all the existing `AEK_FOO` ids to values that don't fit in 32 bits, and making sure the whole test suite still passes. That should catch any remaining cases where an integer type should have been widened. CHANGES

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki added a comment. In D73906#1856615 , @simon_tatham wrote: > I wonder if it's worth temporarily redefining all the existing `AEK_FOO` ids > to values that don't fit in 32 bits, and making sure the whole test suite > still passes. That should

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 ___ cfe-commits mailing list

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki updated this revision to Diff 242277. miyuki added a comment. More missing unsigned->uint64_t changes, removed a redundant `getAEKID` function (identical to `parseArchExt`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files:

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

dmgreen added a comment. I added some `This?`'s around, which may or may not be needed too. Comment at: llvm/include/llvm/Support/ARMTargetParser.h:196 unsigned DefaultFPU; unsigned ArchBaseExtensions; T ID; This? Comment at:

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62298 tests passed, 121 failed and 845 were skipped. failed: Clang.CXX/modules-ts/basic/basic_link/p3.cppm failed: Clang.CXX/modules-ts/codegen-basics.cppm failed: Clang.CodeGen/arm-aapcs-vfp.c failed:

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki updated this revision to Diff 242114. miyuki added a comment. Fix one missing unsigned->uint64_t occurrence CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki created this revision. miyuki added reviewers: simon_tatham, eli.friedman, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch changes the underlying type of the ARM::ArchExtKind enumeration to