[PATCH] D74036: [clangd] don't rename on protobuf symbols.

2020-02-06 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd6da8a1d9453: [clangd] don't rename on protobuf symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74036/new/ https://reviews.llvm

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

2020-02-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 242892. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74036/new/ https://reviews.llvm.org/D74036 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extr

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

2020-02-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:99 bool isBlacklisted(const NamedDecl &RenameDecl) { + if (isProtoFile(RenameDecl.getLocation(),

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

2020-02-05 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

2020-02-05 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74036 Files: clang-tools-extra/clangd/refactor/Rename.