[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG863d9752105f: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242640. bader added a comment. Applied clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242639. bader added a comment. Refactor clang/lib/Driver/ToolChains/Clang.cpp in accordance with Alexey's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4028-4030 + Arg *SYCLArg = Args.getLastArg(options::OPT_fsycl, options::OPT_fno_sycl); + if (SYCLArg) +IsSYCL = SYCLArg->getOption().matches(options::OPT_fsycl); I suggest to

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader marked 3 inline comments as done. bader added a comment. Thanks for the prompt review. I've applied your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242627. bader added a comment. Applied suggestions from Alexey Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242590. bader added a comment. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3411-3413 +// C++ SYCL options +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; Usually, we add a pair of such flags, `-fsycl`

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. As a first step this implementation enables compilation of the offload code. Repository: rG LLVM Github Monorepo