[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. (I am working on rebasing this; tests need updating for opaque ptr) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

jroelofs added a subscriber: lei. jroelofs added a comment. In D74094#4559037 , @dexonsmith wrote: > In D74094#4554327 , @foad wrote: > >> Hi @erik.pilkington, I see this got reverted: > > I'm not sure if

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

dexonsmith added subscribers: arphaman, akyrtzi, jroelofs. dexonsmith added a comment. In D74094#4554327 , @foad wrote: > Hi @erik.pilkington, I see this got reverted: I'm not sure if @erik.pilkington is still watching Phabricator, but in any case I

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. In D74094#4554327 , @foad wrote: > Hi @erik.pilkington, I see this got reverted: > > commit e26c24b849211f35a988d001753e0cd15e4a9d7b > Author: Erik Pilkington > Date: Wed Feb 12 12:02:58 2020 -0800 > >

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

foad added a comment. Herald added a project: All. Hi @erik.pilkington, I see this got reverted: commit e26c24b849211f35a988d001753e0cd15e4a9d7b Author: Erik Pilkington Date: Wed Feb 12 12:02:58 2020 -0800 Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

This revision was automatically updated to reflect the committed changes. Closed by commit rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3687 - args.add(EmitAnyExprToTemp(E), type); } thegameg wrote: > Is there any other use of `EmitAnyExprToTemp` that can benefit

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3687 - args.add(EmitAnyExprToTemp(E), type); } Is there any other use of `EmitAnyExprToTemp` that can benefit from this? CHANGES SINCE LAST ACTION

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington updated this revision to Diff 243243. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Disable the optimization for non-trivially destructible types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } erik.pilkington wrote: > rjmccall wrote: > > If the argument type has a C++ destructor, will we end its lifetime before > > we call

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington planned changes to this revision. erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } rjmccall wrote: > If the

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } If the argument type has a C++ destructor, will we end its lifetime before we call destructors at the end of the full-expression?

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, thegameg, rsmith. Herald added subscribers: ributzka, dexonsmith, jkorous. These temporaries are only used in the callee, and their memory can be reused after the call is complete. rdar://58552124