[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

estewart08 added a comment. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Herald added a project: All. In D74144#2308856 , @ABataev wrote: > In D74144#2308796 , @cchen wrote: > >> In

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. In D74144#2308796 , @cchen wrote: > In D74144#2307494 , @ABataev wrote: > >> In D74144#2307454 , @cchen wrote: >> >>> @ABataev, the below test is

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

cchen added a comment. In D74144#2307494 , @ABataev wrote: > In D74144#2307454 , @cchen wrote: > >> @ABataev, the below test is extracted from Sollve test suite and Clang now >> emit: >> >> test.c:17:35: error:

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. In D74144#2307454 , @cchen wrote: > @ABataev, the below test is extracted from Sollve test suite and Clang now > emit: > > test.c:17:35: error: subscripted value is not an array or pointer > #pragma omp target update

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

cchen added a comment. Herald added subscribers: sstefan1, yaxunl. @ABataev, the below test is extracted from Sollve test suite and Clang now emit: test.c:17:35: error: subscripted value is not an array or pointer #pragma omp target update to( (([N][N])foo)[1:M] )

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac9efb0c322: [OPENMP50]Add basic support for array-shaping operation. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D74144?vs=252859=253584#toc Repository: rG LLVM Github

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 252859. ABataev added a comment. Rebase + fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files: clang/include/clang-c/Index.h

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall added a comment. Okay, if you think that suppress array decay is the right behavior here, that's fine with me. Please check the behavior of other OpenMP implementations, though. Comment at: clang/lib/Sema/SemaExpr.cpp:4848 + Expr::EvalResult EvResult; +

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 252700. ABataev added a comment. Rebase + fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files: clang/include/clang-c/Index.h

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall added a comment. > We cannot build an array type since this expression does not represent a > supported array type. Sizes may be non-constant anywhere in the operation, > variable array type does not support it. I don't think that's true; the element type of a C99 VAT can still be

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked 4 inline comments as done. ABataev added a comment. In D74144#1941971 , @rjmccall wrote: > Okay, so these array-shaping expressions are only allowed as operands to > specific OpenMP directives? That's a plausible interpretation of "The >

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4751 + LParenLoc, RParenLoc, Dims, Brackets); + if (!BaseTy->isAnyPointerType()) +return ExprError(Diag(Base->getExprLoc(),

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

rjmccall added a comment. Okay, so these array-shaping expressions are only allowed as operands to specific OpenMP directives? That's a plausible interpretation of "The shape-operator can appear only in clauses where it is explicitly allowed" from the spec

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

jdoerfert added a comment. My questions are answered, as you have the clang people in the reviewer list and I was only added by my OpenMP hook, I would them to OK this. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev updated this revision to Diff 248789. ABataev marked an inline comment as done. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files:

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked 6 inline comments as done. ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && jdoerfert

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && Out of curiosity, why do we prevent Objective C here?

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Herald added a subscriber: martong. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev created this revision. ABataev added reviewers: rjmccall, rsmith. Herald added subscribers: arphaman, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Added basic representation and parsing/sema handling of array-shaping operations. Array shaping expression is