This revision was automatically updated to reflect the committed changes.
Closed by commit rGa7fd548a4f9e: [clang-rename] Fix the missing template
constructors. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74216/new/
hokein updated this revision to Diff 243753.
hokein marked an inline comment as done.
hokein added a comment.
Fix the format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74216/new/
https://reviews.llvm.org/D74216
Files:
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Should be good to go, please run `git-clang-format` on the changes just to make
sure.
Thanks for fixing this!
Comment at:
hokein updated this revision to Diff 243752.
hokein marked 3 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74216/new/
https://reviews.llvm.org/D74216
Files:
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:144
+ template
+ [[Foo]]();
+
nit: Maybe also add `^` to this one and the one below?
Comment at:
hokein created this revision.
hokein added a reviewer: kbobyrev.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
When renaming a class with template constructors, we are missing the
occurrences of the template constructors, because
