[PATCH] D74229: [Clang] Cover '#pragma clang __debug overflow_stack' in tests

2020-02-07 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea planned changes to this revision. aganea added a comment. Withdrawing this, I found an crash in Debug build. I think this can't work without doing all the crash processing in a separate, pre-allocated thread. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D74229: [Clang] Cover '#pragma clang __debug overflow_stack' in tests

2020-02-07 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea created this revision. aganea added reviewers: rnk, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1148 +#ifdef __clang__ + __attrib

[PATCH] D74229: [Clang] Cover '#pragma clang __debug overflow_stack' in tests

2020-02-07 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1148 +#ifdef __clang__ + __attribute__((optnone)) Would it be better if we had something like `LLVM_[DISABLE|ENABLE]_OPT` in `Compiler.h` instead of th