davezarzycki abandoned this revision.
davezarzycki added a comment.
I'm abandoning this due to lack of time and the problem being more involved
than I thought.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74298/new/
davezarzycki added a comment.
Hi @MaskRay – I was just looking at the source history. I didn't test the old
way. As it turns out there isn't a regression, but just some unexplained code
in the current clang option parsing. And the `-disable-O0-optnone` is a useful
hint. Thanks! I've been
MaskRay added a comment.
Why you say regression, do you have a case where
fcd33149b48885ab8e4ca4ffb6977bce5be2e623 actually regressed things?
-O0 implies optnone. For `-Xclang -disable-O0-optnone -O0 -finline-functions`,
the patch can indeed make a difference. `-disable-O0-optnone` is
davezarzycki added a comment.
Hi @lebedev.ri – Before I add a small new test file, is there an existing one
that you know of that would be good to extend?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74298/new/
https://reviews.llvm.org/D74298
lebedev.ri added a comment.
This clearly needs tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74298/new/
https://reviews.llvm.org/D74298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
davezarzycki created this revision.
davezarzycki added a reviewer: chandlerc.
davezarzycki added a project: clang.
This fixes a regression introduced (over three years ago!) by
fcd33149b48885ab8e4ca4ffb6977bce5be2e623.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D74298
