[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman added a comment. In D74299#2339994 , @AlexanderLanin wrote: > I cannot reproduce the problem and there is just not enough info to go on. Ugh, I hate when that happens. :-( > Is there any way to get anything in addition? e.g. run the same

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. I cannot reproduce the problem and there is just not enough info to go on. Is there any way to get anything in addition? e.g. run the same test with `-vv` or add some additional print commands? Maybe it's some access rights problem, or different version of some

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman added a comment. In D74299#2338823 , @aaron.ballman wrote: > In D74299#2338772 , @AlexanderLanin > wrote: > >> Could someone commit this as I cannot? Thanks a lot! >> Alexander Lanin >> >> Thanks

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman closed this revision. aaron.ballman added a comment. In D74299#2338772 , @AlexanderLanin wrote: > Could someone commit this as I cannot? Thanks a lot! > Alexander Lanin > > Thanks for review @aaron.ballman! Happy to do so! I've commit on

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin marked an inline comment as done. AlexanderLanin added a comment. Could someone commit this as I cannot? Thanks a lot! Alexander Lanin Thanks for review @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin updated this revision to Diff 298566. AlexanderLanin added a comment. Readd removed 'print help without crashing' test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 Files:

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin planned changes to this revision. AlexanderLanin added a comment. The reason was that I thought that line doesn't do anything. Of course "not crashing" is a valid expectation. If nothing else, then "not crashing" should indeed be tested. I'll try to improve this ancient diff.

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

aaron.ballman added a comment. Generally looks good to me, but I had a question about test coverage. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/run-clang-tidy_config-file.cpp:1 -// RUN: %run_clang_tidy --help // RUN: rm -rf %t Is there a

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. *ping* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. *ping* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. *ping* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org