[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > I'll submit it today. Done, see: https://reviews.llvm.org/D74907 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. In D74564#1884675 , @thakis wrote: > Great, thanks. Since we're currently broken due to this change, any ETA for > the follow-up? I'll submit it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74564: libclang: Add static build support for Windows

thakis added a comment. Great, thanks. Since we're currently broken due to this change, any ETA for the follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > Given that this is currently a breaking change: Does it make sense to re-use > LLVM_ENABLE_PIC for this, which currently doesn't have an effect on Windows > anywhere? Maybe there should be a dedicated "I want libclang to be a static > library" opt-in? And maybe

[PATCH] D74564: libclang: Add static build support for Windows

thakis added a comment. Another question: We have a bot that builds LLVM with this cmake config: 'cmake', '-GNinja', '-DCMAKE_BUILD_TYPE=Release', '-DLLVM_ENABLE_ASSERTIONS=OFF', '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;lld;chrometools;clang-tools-extra',

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) thakis wrote: > Is this enough?

[PATCH] D74564: libclang: Add static build support for Windows

thakis added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) Is this enough? Every target that depends on libclang now needs to define

[PATCH] D74564: libclang: Add static build support for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff1f55a1219: libclang: Add static build support for Windows (authored by cristian.adam, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. @mstorsjo can you help me with pushing this commit? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commits

[PATCH] D74564: libclang: Add static build support for Windows

yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam updated this revision to Diff 244944. cristian.adam marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 Files: clang/include/clang-c/Platform.h

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif yvvan wrote: > Is it different from just leaving CINDEX_LINKAGE empty? On

[PATCH] D74564: libclang: Add static build support for Windows

yvvan added a comment. Please, upload patches with context (-U). Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif Is it different from just leaving

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. Build with this patch being built on GitHub Actions on Windows MSVC, Windows MinGW, Linux, macOS: https://github.com/cristianadam/llvm-project/actions/runs/38838989 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: chapuni, yvvan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. On Linux and macOS it was possible to build libclang statically by configuring CMake with: -D LIBCLANG_BUILD_STATIC=ON -D