This revision was automatically updated to reflect the committed changes.
Closed by commit rGd42711625af8: [ARM] Creating 'call_mangled' for
Neon intrinsics definitions (authored by pratlucas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74618/new/
pratlucas updated this revision to Diff 249979.
pratlucas added a comment.
Adding example to call_mangled description comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74618/new/
https://reviews.llvm.org/D74618
Files:
clang/include/clang/Ba
dnsampaio accepted this revision.
dnsampaio added a comment.
This revision is now accepted and ready to land.
LGTM, after a nit inline.
Comment at: clang/include/clang/Basic/arm_neon_incl.td:66
+//that has the variation and takes the given types, an error
+//
pratlucas updated this revision to Diff 248659.
pratlucas added a comment.
Applying clang-format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74618/new/
https://reviews.llvm.org/D74618
Files:
clang/include/clang/Basic/arm_neon_incl.td
clang/
pratlucas updated this revision to Diff 248505.
pratlucas added a comment.
Addressing review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74618/new/
https://reviews.llvm.org/D74618
Files:
clang/include/clang/Basic/arm_neon_incl.td
cla
dnsampaio added inline comments.
Comment at: clang/utils/TableGen/NeonEmitter.cpp:1890-1891
}
+if (MangledName)
+ Good &= I.getMangledName(true) == MangledName;
+
Can we move this above the loop just before? Perhaps, if false, can we just
continue
pratlucas created this revision.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a project: clang.
As multiple versions ofthe same Neon intrinsic can be created through
the same TableGen definition with the same argument types, the existing
'call' operator is not always able to
