dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:4566
+ 0b0, VTI.Unsigned>;
+ defvar unpred_op = !if(VTI.Unsigned, unpred_op_u, unpred_op_s);
miyuki marked an inline comment as done.
miyuki added inline comments.
Comment at: clang/test/CodeGen/arm-mve-intrinsics/vaddq.c:2
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
-// RUN: %clang_cc1 -triple thumbv8.1m.main-arm-none-eabi
dmgreen added a comment.
I like how this uses a splat for all the register arguments. That sounds like a
good idea.
The one's that worry me are the floating point instructions. Last time we tried
those it was actually causing performance regressions because of extra sp->gpr
mov's left in the
miyuki added a comment.
I would prefer not to format the Clang test cases to avoid code churn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74620/new/
https://reviews.llvm.org/D74620
___
cfe-commits
