[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added inline comments. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + thakis wrote: > Why do you need this feature? clang invocations that want to use the platfo

[PATCH] D74704: Support -fuse-ld=lld for riscv

thakis added inline comments. Herald added subscribers: frasercrmck, NickHung. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + Why do you need this feature? clang invocations that

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Submitted fixes in d2cbaf1755ffa90300365c0d71400a5ee4ada3bd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 08:08:49PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Unsure if my reply was sent over email so copying it here. > > Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to > fix it. Thanks. Will you be sending out

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Unsure if my reply was sent over email so copying it here. Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to fix it. Thanks. Will you be sending out the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Yup, I added it to both *-extra.c files and it seemed to fix the tests. On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton wrote: > Does adding > > // REQUIRES: platform-linker > > to Driver/riscv32-toolchain-extra.c fixes your issue? > > > On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Will you be sending out the patch for this? On Wed, Feb 26, 2020 at 12:05 PM Leonard Chan wrote: > Yup, I added it to both *-extra.c files and it seemed to fix the tests. > > On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton > wrote: > >> Does adding >> >> // REQUIRES: platform-linker >> >> to Dri

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Does adding // REQUIRES: platform-linker to Driver/riscv32-toolchain-extra.c fixes your issue? On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 >

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 > > might've broken our toolchain again: s***t. Can y

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 might've broken our toolchain again: FAIL: Clang :: Driver/riscv32-toolchain-extra.c (5723 of 17018) TEST 'Clang

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe058667a2e01: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 245805. serge-sans-paille added a comment. Add a configure feature test to filter out tests that depend on platform linker, as hinted by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/ne

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. For the record: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Ariscv64-toolchain.c fails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704

[PATCH] D74704: Support -fuse-ld=lld for riscv

MaskRay added a comment. The problem may be `-DCLANG_DEFAULT_LINKER=lld`. (FWIW I really don't like supporting numerous -D configurations and ask authors to revert because of some weird -D configurations.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. Reverted through b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D7

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added a comment. I'll revert and propose an updated patch then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704 ___ cfe-commits mailing list c

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. In D74704#1881012 , @vvereschaka wrote: > Hello @serge-sans-paille, > > looks like these changes broke the ARM builders: > http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749 > http://lab.llvm.org:8011/build

[PATCH] D74704: Support -fuse-ld=lld for riscv

vvereschaka added a comment. Hello @serge-sans-paille, looks like these changes broke the ARM builders: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4752 failed tests: - FAIL: Clang::riscv64-toolchain.c -

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd230142d8a0: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. In D74704#1878944 , @jrtc27 wrote: > This isn't a new problem. The Linux and FreeBSD toolchains already support > -fuse-ld=lld properly, it's just the

[PATCH] D74704: Support -fuse-ld=lld for riscv

jrtc27 added a comment. In D74704#1878921 , @lenary wrote: > I am worried about the interaction between `-fuse-ld=lld` and linker > relaxation (which is not supported by LLD, as I understand it) > > 1. clang could ignore `-fuse-ld=lld` when linker relaxat

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary added a comment. I am worried about the interaction between `-fuse-ld=lld` and linker relaxation (which is not supported by LLD, as I understand it) 1. clang could ignore `-fuse-ld=lld` when linker relaxation is enabled 2. clang could ignore (disable) linker relaxation if `-fuse-ld=lld` i

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 244943. serge-sans-paille added a comment. Add test case. This test fails with current master, see https://bugzilla.redhat.com/show_bug.cgi?id=1803698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D747

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille created this revision. serge-sans-paille added a reviewer: asb. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, Ma