This revision was automatically updated to reflect the committed changes.
Closed by commit rG2eff1c3ce48e: [clang-format] Extend
AllowShortLoopsOnASingleLine to do ... while loops. (authored by
mitchell-stellar).
Changed prior to commit:
https://reviews.llvm.org/D75022?vs=246512=248748#toc
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for adding the extra test, please mark the inline comments as
done
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
mitchell-stellar added a comment.
Not that I am aware of. Whoever ends up doing the merge will likely run the
necessary tests before committing. If you've run as many as you can, then
hopefully all will be fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
DaanDeMeyer added a comment.
Is there CI infra that runs for each revision? I verified all the format unit
tests still pass but I haven't run the entire test suite on my machine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
https://reviews.llvm.org/D75022
mitchell-stellar accepted this revision.
mitchell-stellar added a comment.
Assuming this passes all existing tests, LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
https://reviews.llvm.org/D75022
___
cfe-commits mailing list
DaanDeMeyer updated this revision to Diff 246512.
DaanDeMeyer added a comment.
Added extra unit tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
https://reviews.llvm.org/D75022
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index:
MyDeveloperDay added a comment.
I think its look good, please add the extra tests, then lets give people a
couple of days
Comment at: unittests/Format/FormatTest.cpp:570
+ AllowsMergedLoops);
}
horrible code though they are, could you add a
DaanDeMeyer updated this revision to Diff 246244.
DaanDeMeyer added a comment.
Added unit tests and fixed the case where stuff follows the do statement (like
a comment).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
https://reviews.llvm.org/D75022
Files:
MyDeveloperDay added a comment.
You need to add unit tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
https://reviews.llvm.org/D75022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DaanDeMeyer updated this revision to Diff 246150.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75022/new/
https://reviews.llvm.org/D75022
Files:
clang/lib/Format/UnwrappedLineFormatter.cpp
Index: clang/lib/Format/UnwrappedLineFormatter.cpp
10 matches
Mail list logo