[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty],

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

hoyFB added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty], [llvm_v

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e9747b50bcb: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D75162?vs=247288&id=247454#toc Repos

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https://reviews.llvm.org/D75162 ___

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon updated this revision to Diff 247288. RKSimon added a comment. Add strict fp codegen tests - this means the patch is now dependent on D75304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https:/

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper added a comment. In D75162#1896469 , @RKSimon wrote: > In D75162#1896365 , @craig.topper > wrote: > > > Should we check that this generates constrained.fpext in strict mode? > > > Sure - where is the b

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper added a comment. I've posted https://reviews.llvm.org/D75304 to make the backend recognize the strict version of this pattern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https://reviews.llvm.org/D75162 ___

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon added a comment. In D75162#1896365 , @craig.topper wrote: > Should we check that this generates constrained.fpext in strict mode? Sure - where is the best place(s) to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

craig.topper added a comment. Should we check that this generates constrained.fpext in strict mode? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https://reviews.llvm.org/D75162 ___ cfe-comm

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This removes everything but int_x86_avx512_mask_vcvtph2ps_512 which provides the SAE variant, but even this can use the fpext generic