This revision was automatically updated to reflect the committed changes.
kadircet marked 2 inline comments as done.
Closed by commit rG2bb7774ddf00: [clangd] Get rid of getBeginningOfIdentifier
helper (authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D75176?vs=246729&id
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Did you want to delete the lexer check in getDeducedType or is that another
patch?
Comment at: clang-tools-extra/clangd/Hover.cpp:533
+ }
+ auto TokensAroundCursor =
kadircet updated this revision to Diff 246729.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Only use special locations for deducedtype and macros.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75176/new/
https://reviews.ll
sammccall added a comment.
Hooray!
Comment at: clang-tools-extra/clangd/Hover.cpp:537
+ // We prefer the identifiers if any, otherwise make use of the first token.
+ SourceLocation SourceLocationBeg = TokensAroundCursor.front().location();
first -> last I t
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
kadircet added a parent revision: D75166: [clangd] Clean-up XRefs.cpp from
Lexer usages and unnecessary
