[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

sammccall added a comment. In D75602#1906587 , @thakis wrote: > This broke building on my bots: > > http://45.33.8.238/linux/11862/step_4.txt > > `ld.lld: error: undefined symbol: > clang::clangd::TUScheduler::InvalidatedError::ID` > > Looks like that is

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

thakis added a comment. This broke building on my bots: http://45.33.8.238/linux/11862/step_4.txt `ld.lld: error: undefined symbol: clang::clangd::TUScheduler::InvalidatedError::ID` Looks like that is indeed declared in this change, but it doesn't have a definition. Repository: rG LLVM

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc627b120eb8b: [clangd] Cancel certain operations if the file changes before we start. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

sammccall updated this revision to Diff 248336. sammccall marked 7 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75602/new/ https://reviews.llvm.org/D75602 Files:

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:58 +/// without any explicit user action. +static TUScheduler::ASTActionInvalidation LikelyImplicit = +TUScheduler::InvalidateOnUpdate; nit: i would actually keep

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Comment at: clang-tools-extra/clangd/Cancellation.cpp:39 + return true; return false; // Not in scope of a task. } comment seems

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Otherwise they can force us to build lots of snapshots that we don't need.