[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511 + // + // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't + // take arguments and doesn't model parameter initialization because there is

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG59a960b83c2d: [analyzer] Skip analysis of inherited ctor as top-level function (authored by martong). Changed prior to commit:

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511 + // + // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't + // take arguments and doesn't model parameter

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511 + // + // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't + // take arguments and doesn't model parameter initialization because there is

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong added a comment. Ping. Please prioritize this patch, since it is fixing a regression caused by https://reviews.llvm.org/D74735. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong updated this revision to Diff 248678. martong added a comment. - Remove superfluous param x from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 Files:

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong updated this revision to Diff 248473. martong marked an inline comment as done. martong added a comment. - Change comments, add FileCheck test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 Files:

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong marked an inline comment as done. martong added a comment. In D75678#1907449 , @NoQ wrote: > Thanks!! I also recommend a more direct test with `-analyzer-display-progress > | FileCheck`. Ok, I added a new test file with FileCheck.

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

Szelethus added a comment. I followed the discussion, on the other patch, and this seems to be the appropriate fix -- I lack the confidence to accept, but LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ added a comment. Thanks!! I also recommend a more direct test with `-analyzer-display-progress | FileCheck`. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:507-508 + // Skip analysis of inherited constructors as top-level functions because we + //

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong added a comment. For those who are interested in more details please refer to the related discussion after the commit of the patch that introduces handling of inherited ctors . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong created this revision. martong added a reviewer: NoQ. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. Herald