[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +// UNMANGLED: define {{.*}}void @test1( +} erichkeane wrote: > Anastasia wrote: > >

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +// UNMANGLED: define {{.*}}void @test1( +} Anastasia wrote: > erichkeane wrote: > >

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked 3 inline comments as done. erichkeane added a comment. Both done here: fe5c719eaf572e23b700e75832ec37a3761b337b . Thanks for the review @Anastasia Comment at:

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added a comment. Sorry for the delayed comments. It would be good to address those in a separate commit if possible. Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +//

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG86e0a6c60627: Add MS Mangling for OpenCL Pipe types, add mangling test. (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Does anyone have any comments for me? This is blocking using pipes on windows targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! I would expect this to be non-controversial, but if there is a different reviewer anyone can suggest, I'd appreciate it! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } erichkeane wrote: > Anastasia wrote: > > erichkeane

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } Anastasia wrote: > erichkeane wrote: > > Anastasia

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } erichkeane wrote: > Anastasia wrote: > > We don't seem to add namespace for other OpenCL types,

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

bader added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! Anyone else have feedback? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane updated this revision to Diff 249367. erichkeane added a comment. Thanks @Anastasia for the review! Comments inline. Moved the test as requested, and added OpenCL tests for both OSes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane marked 3 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } Anastasia wrote: > We don't seem to add namespace for

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2956 + + mangleArtificialTagType(TTK_Struct, TemplateMangling, {"__clang"}); } We don't seem to add namespace for other OpenCL types, although I am not against it as I find it

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane added a comment. Ping! @Anastasia I was hoping for your input on this, since it is OpenCLC++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing list

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

erichkeane created this revision. erichkeane added reviewers: bader, Anastasia, pxli168. Herald added a subscriber: yaxunl. SPIRV2.0 Spec only specifies Linux mangling, however our downstream has use for a Windows mangling for these types. Unfortunately, the SPIRV spec specifies a single