[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

This revision was automatically updated to reflect the committed changes. Closed by commit rG704cd4d5d075: [clangd] Only minimally escape text when rendering to markdown. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet added a comment. thanks, still LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall marked an inline comment as done. sammccall added a comment. Filed https://github.com/google/llvm-premerge-checks/issues/147 for the spurious unit test failure. Comment at: clang-tools-extra/clangd/FormattedString.cpp:150 +// Not a delimiter if surrounded by

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall updated this revision to Diff 250730. sammccall added a comment. Fix '_' rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 Files: clang-tools-extra/clangd/FormattedString.cpp

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/FormattedString.cpp:150 +// Not a delimiter if surrounded by space. +return !SpaceSurrounds(); + case '-': //

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall added a comment. Sorry for the slow turnaround, bit off more than I could chew on a few fronts :-( Comment at: clang-tools-extra/clangd/FormattedString.cpp:69 +return false; + if (Contents.front() == '!' || Contents.front() == '?' || + Contents.front() ==

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall updated this revision to Diff 250624. sammccall marked 10 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 Files:

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet added a comment. Just writing down my investigation results for context: Looks like we'll never escape `$%'(,/:;?@[^{|}` anymore. Markdown already doesn't provide backslash escaping for `$%',/:;?@^|` which leaves us with parentheses `([{}`: - `[` looks fine as it is only used for

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall updated this revision to Diff 248493. sammccall added a comment. couple more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 Files: clang-tools-extra/clangd/FormattedString.cpp

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Conservatively escaping everything is bad in coc.nvim which shows the markdown to the user, and we