hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75779/new/
https://reviews.llvm.org/D75779
hfinkel added inline comments.
Comment at: clang/lib/AST/DeclarationName.cpp:147
+Name = Name.split(getOpenMPVariantManglingSeparatorStr()).first;
+ OS << Name;
+}
Would it make sense to print " (omp variant)" after the name to disambiguate?
jdoerfert added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396
+ IdentifierInfo = Context.Idents.get(
+ (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str());
+ D.SetIdentifier(, D.getBeginLoc());
hfinkel wrote:
> jdoerfert
hfinkel added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396
+ IdentifierInfo = Context.Idents.get(
+ (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str());
+ D.SetIdentifier(, D.getBeginLoc());
jdoerfert wrote:
> hfinkel
jdoerfert added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396
+ IdentifierInfo = Context.Idents.get(
+ (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str());
+ D.SetIdentifier(, D.getBeginLoc());
hfinkel wrote:
> Is there any
hfinkel added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1253
+: Error<"expected '#pragma omp begin declare variant' to match this stray "
+"`#pragma omp end delcare variant`">;
def err_omp_declare_target_unexpected_clause:
