[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c70dec18c7e: [libunwind] Remove __FILE__ and __LINE__ from error reporting (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

phosek added a comment. In D75890#1915493 , @thakis wrote: > `__FILE__` only expands to an absolute path if you pass an absolute path to > clang (ctrl-f "__FILE__" on > http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). Yes,

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

leonardchan added a comment. In D75890#1915493 , @thakis wrote: > `__FILE__` only expands to an absolute path if you pass an absolute path to > clang (ctrl-f "__FILE__" on > http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). > >

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

saugustine accepted this revision. saugustine added a comment. This looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/new/ https://reviews.llvm.org/D75890 ___ cfe-commits mailing

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

thakis added a comment. `__FILE__` only expands to an absolute path if you pass an absolute path to clang (ctrl-f "__FILE__" on http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). It feels like this is working around a deficiency in the compiler. Maybe fixing

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you might want to wait a few more hours for other reviewers to see if anyone has objections. Comment at: libunwind/src/config.h:125 do {

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

leonardchan updated this revision to Diff 249468. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/new/ https://reviews.llvm.org/D75890 Files: libunwind/src/config.h Index: libunwind/src/config.h