[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

craig.topper abandoned this revision. craig.topper added a comment. This was superceded by D76812 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75934/new/ https://reviews.llvm.org/D75934 ___ cfe-commits

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

mattdr added a comment. I accidentally spent time reviewing this, only to cross-reference something in the LLVM code and find another diff (https://reviews.llvm.org/D76812) was written to answer Zola's request and has already been submitted. CHANGES SINCE LAST ACTION

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

zbrid added a comment. I followed up with Chandler about whether it would make sense to integrate this with the existing retpolines pass as you and Craig suggested. He supported the idea. Could you create a new patch(es) to do the refactor/renaming of the retpolines thunking pass and

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

sconstab marked 12 inline comments as done. sconstab added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionIndirectThunks.cpp:79 + +bool X86LoadValueInjectionIndirectThunksPass::doInitialization(Module ) { + InsertedThunks = false; zbrid

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

sconstab updated this revision to Diff 251193. sconstab added a comment. Addressed some of Zola's comments, and removed some unnecessary assertions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75934/new/ https://reviews.llvm.org/D75934 Files: clang/include/clang/Driver/Options.td

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionIndirectThunks.cpp:92 + + // Don't skip functions with the "optnone" attr but participate in opt-bisect. + const Function = MF.getFunction(); zbrid wrote: > Why did you

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

zbrid added a comment. Looks great! Thanks for writing this! I had a bunch of nits (sorry!) and a few questions, otherwise LGTM. Please wait for sign off from at least one other person before submitting. Comment at: llvm/lib/Target/X86/X86FastISel.cpp:3210 // Functions