rsmith added inline comments.
Comment at: clang/include/clang/Lex/Preprocessor.h:749-750
+/// The set of the included headers' UID for the submodule.
+std::set IncludedFiles;
+
A `std::set` is a very heavy object to be copying each time a module is
oontvoo added a comment.
jyknight@ Hi, pinging again (sorry!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
___
cfe-commits mailing list
oontvoo updated this revision to Diff 254384.
oontvoo added a comment.
Update docs.
Note: The failure looks spurious ... They seemed to pass locally for me:
One eg:
[hi on] vyng@vyng:~/repo/llvm-project$ ./build/bin/llvm-lit -v
./clang/test/ClangScanDeps/modules-full.cpp
llvm-lit:
oontvoo updated this revision to Diff 254321.
oontvoo added a comment.
clean up ... Ready to review. PTAL! =)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253623.
oontvoo added a comment.
Rebaase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253388.
oontvoo added a comment.
Add more tests (From Bug 39206)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253382.
oontvoo added a comment.
Update tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253289.
oontvoo added a comment.
cleanup logging
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253245.
oontvoo added a comment.
Updated tests and get it to pass
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253175.
oontvoo added a comment.
Merge master
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253162.
oontvoo added a comment.
Add tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253157.
oontvoo added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 253155.
oontvoo added a comment.
Also serialise non-mods' imported headers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
oontvoo updated this revision to Diff 252791.
oontvoo added a comment.
Handle includes/import from outer mods
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252768.
oontvoo added a comment.
Handle textual headers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252760.
oontvoo added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252761.
oontvoo added a comment.
.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252738.
oontvoo added a comment.
...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252735.
oontvoo added a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252728.
oontvoo added a comment.
Typo - missing ! operator
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252685.
oontvoo added a comment.
Handle the case where the file is first seen
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
oontvoo added a comment.
@jyknight Actually, please hold on on the review ... still working on it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
___
oontvoo updated this revision to Diff 252371.
oontvoo added a comment.
clang format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo marked an inline comment as done.
oontvoo added a comment.
Addressed comments. PTAL. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
___
oontvoo updated this revision to Diff 252237.
oontvoo added a comment.
Cleanup
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252205.
oontvoo added a comment.
Fix build errors
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252206.
oontvoo added a comment.
Clang format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252203.
oontvoo added a comment.
(hopefully) Final revision ... running out of idea for edit comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
oontvoo updated this revision to Diff 252118.
oontvoo added a comment.
Clear pending action.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 252117.
oontvoo marked an inline comment as done.
oontvoo added a comment.
Add a PendingHeaderSearch set
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
oontvoo updated this revision to Diff 252110.
oontvoo added a comment.
Updated the reader to read the UIDs first, then we'll build up the Importers
list at the end.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
oontvoo updated this revision to Diff 251804.
oontvoo added a comment.
Removed accidentally committed file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/HeaderSearch.h
oontvoo updated this revision to Diff 251801.
oontvoo marked an inline comment as done.
oontvoo added a comment.
Additional change: Also keep "Importers" and de/serialise these.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
oontvoo marked an inline comment as done and an inline comment as not done.
oontvoo added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:1266
+ if (PP.isIncludeVisibleInLocalModule(File, M)) return false;
+ else PP.setIncludeVisibleForHeader(File, M);
+
oontvoo marked an inline comment as done.
oontvoo added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:1266
+ if (PP.isIncludeVisibleInLocalModule(File, M)) return false;
+ else PP.setIncludeVisibleForHeader(File, M);
+} else {
jyknight added a comment.
I suspect we also need to support saving/loading some of this information in
the serialized AST, e.g. clang/lib/Serialization/ASTWriter.cpp has code to save
the HeaderInfo data, around line 1650. And around line 2174, code to save the
macros per submodule. We'll also
oontvoo updated this revision to Diff 249717.
oontvoo added a comment.
Wrong name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/Preprocessor.h
oontvoo updated this revision to Diff 249712.
oontvoo added a comment.
update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/Preprocessor.h
oontvoo updated this revision to Diff 249711.
oontvoo added a comment.
More typo correction
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/Preprocessor.h
oontvoo updated this revision to Diff 249708.
oontvoo added a comment.
Updated typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
clang/include/clang/Lex/Preprocessor.h
oontvoo updated this revision to Diff 249690.
oontvoo retitled this revision from "draft " to "draft".
oontvoo added a comment.
Updated
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75951/new/
https://reviews.llvm.org/D75951
Files:
41 matches
Mail list logo