[PATCH] D75983: [clang-format] Improved identification of C# nullables

2020-03-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1fb9c29833ab: [clang-format] Improved identification of C# nullables (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75983: [clang-format] Improved identification of C# nullables

2020-03-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75983/new/ https://reviews.llvm.org/D75983 ___ cfe-commits mailing list cfe

[PATCH] D75983: [clang-format] Improved identification of C# nullables

2020-03-11 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 249596. jbcoe added a comment. Fix nits from review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75983/new/ https://reviews.llvm.org/D75983 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/un

[PATCH] D75983: [clang-format] Improved identification of C# nullables

2020-03-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1016 if (Style.isCSharp()) { -// `Type? name;` and `Type? name =` can only be nullable types. +// `Type?)`, `Type?>`, `Type? name;`and `Type? name =` can only be +// nul

[PATCH] D75983: [clang-format] Improved identification of C# nullables

2020-03-11 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow '?' inside C# generics. Do not mistake casts like (Type?) as conditional operators. Repository: rG LLVM Gith