[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGb194e7d6313b: [clangd] Change line break behaviour for hoverinfo (authored by lolleko, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D76094?vs=252159&id=252269#toc Reposito

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252159. lolleko added a comment. Final Cleanup Removed markdown linebreak parsing for now. No I don't have commit rights yet. Feel fre to merge this for me. Thanks for the thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252153. lolleko added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76094/new/ https://reviews.llvm.org/D76094 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h c

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252151. lolleko added a comment. Final Cleanup Removed markdown linebreak parsing for now. No I don't have commit rights yet. Feel fre to merge this for me. Thanks for the thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for this! Mostly just some cleanups/comment nits left. The substantive change is around the `\` and ` ` at end-of-line. It looks like the goal is on improving the parsing of mark

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252006. lolleko added a comment. Adressed 2nd Review The problem with the changes you proposed is that it doesn't handle paragraphs (\n\n). I think the conditionals required to make that work wouldn't be much cleaner than the current solution. And I do thi

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

sammccall added a comment. Thanks, this fits in a lot better! I think there's some more details that could be handled, e.g. if a line is much shorter than the max line length, then that probably implies it's a "real" break. But if we get the code structure right, these should be easy to plug in

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 251334. lolleko edited the summary of this revision. lolleko added a comment. Addressed review. Paragraphs (lines separated by a double line break `\n\n`) are currently not retained. Because the current implementation of markup::Paragraph only appends a sin

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

sammccall added a comment. I understand the main goal here is preserving intended line breaks in documentation comments? Thanks for tackling this problem! A design goal here is that the markup objects are the source of truth about the document structure. So if we've decided we want a comment to

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko created this revision. lolleko added a reviewer: sammccall. lolleko added a project: clang. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. `convertLineBreaks` retains hard line breaks and removes soft line breaks. Wether a line break