This revision was automatically updated to reflect the committed changes.
Closed by commit rG6b85032c95be: [clangd] Update TUStatus api to accommodate
preamble thread (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76304/new/
kadircet updated this revision to Diff 254519.
kadircet added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76304/new/
https://reviews.llvm.org/D76304
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:277
build(std::move(*CurrentReq));
+ bool IsEmpty = false;
+ {
sammccall wrote:
> kadircet wrote:
> > sammccall wrote:
> > > Seems clearer to do this
kadircet updated this revision to Diff 252248.
kadircet marked 14 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76304/new/
https://reviews.llvm.org/D76304
Files:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:277
build(std::move(*CurrentReq));
+ bool IsEmpty = false;
+ {
kadircet
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:161
+/// update.
+class TUStatusManager {
+public:
sammccall wrote:
> nit: "manager" doesn't really explain what this is, and it's used both as the
> class name and the main
kadircet updated this revision to Diff 251022.
kadircet marked 8 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76304/new/
https://reviews.llvm.org/D76304
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:161
+/// update.
+class TUStatusManager {
+public:
nit: "manager" doesn't really explain what this is, and it's used both as the
class name and the main description in the
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
javed.absar, ilya-biryukov.
Herald added a project: clang.
TUStatus api had a single thread in mind. This introudces a section
action to represent
