[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-23 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D76379#1930917 , @baloghadamsoftware wrote: > In D76379#1929698 , @Szelethus wrote: > > > The patch looks great, though I'd kindly ask you to wait a bit for someone > > with a bit more

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-23 Thread Balogh, Ádám via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGccc0d351817b: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std… (authored by baloghadamsoftware). Changed prior to commit:

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-19 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D76379#1929698 , @Szelethus wrote: > The patch looks great, though I'd kindly ask you to wait a bit for someone > with a bit more experience on `SVal`-smithing ;)

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-19 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 251320. baloghadamsoftware added a comment. Updated according to the comments and automatic formatting suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76379/new/ https://reviews.llvm.org/D76379 Files:

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. The patch looks great, though I'd kindly ask you to wait a bit for someone with a bit more experience on `SVal`-smithing ;) Generally speaking, I think the word you are looking for is

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-18 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. This patch replaces the verification part of D62895 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76379/new/ https://reviews.llvm.org/D76379

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

2020-03-18 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,