[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bab88b7baa2: Prevent IR-gen from emitting consteval declarations (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D76420?vs=264238=270685#toc Repository: rG LLVM Github

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Looks good. I'd like to eventually get to a point where every `ConstantExpr` that reaches code generation has `hasAPValueResult()` return

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264238. Tyker added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264237. Tyker added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6807-6808 +llvm::SaveAndRestore InConstantContext(Info.InConstantContext, true); return StmtVisitorTy::Visit(E->getSubExpr()); } rsmith wrote: > I don't think this is really

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264236. Tyker marked 12 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files:

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

rsmith added inline comments. Comment at: clang/include/clang/AST/Expr.h:1062 +return ConstantExprBits.APValueKind != APValue::None && + ConstantExprBits.APValueKind != APValue::Indeterminate; } Why do we need to treat indeterminate values

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264023. Tyker added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a parent revision: D74130: [clang] fix consteval call in default arguements . with this patch instead of emitting calls to consteval function. the