wchilders updated this revision to Diff 252357.
wchilders added a comment.
Updated the patch to correct formatting issues, and removed application of the
`ConstantEvaluated` evaluation context to var decls as it introduces too much
complexity.
Additionally removed a fix for `decltype` with
wchilders added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16793-16797
+ if (isManifestlyEvaluatedVar(*this, D)) {
+using ExpressionKind = ExpressionEvaluationContextRecord::ExpressionKind;
+
+PushExpressionEvaluationContext(
+
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16793-16797
+ if (isManifestlyEvaluatedVar(*this, D)) {
+using ExpressionKind = ExpressionEvaluationContextRecord::ExpressionKind;
+
+PushExpressionEvaluationContext(
+
wchilders marked an inline comment as done.
wchilders added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:15597
+ (Rec.isConstantEvaluated() &&
+ Rec.ExprContext != ExpressionKind::EK_ConstexprVarInit)) {
wchilders created this revision.
wchilders added reviewers: Tyker, rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
wchilders marked an inline comment as done.
wchilders added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:15597
+
