[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

2020-05-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Reverted in rG429f03089951d62fb370026905c87f1f25cf220f because its late and this is a breaking change to

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

2020-05-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. This isn't so bad as far as news go, considering you saved a lot of work for me in terms of reproducing this! I'll look into it, thanks! I admit to not use `scan-build` much. :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. Hi @Szelethus , it looks like I am a bearer of bad news again :( This patch seems to crash `scan-build` on pretty much every project that I tested. One way to reproduce: git clone https://github.com/postgres/postgres.git cd postgres/ scan-build -plist-html -o

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

2020-05-19 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe1a3a7e8c8b: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D76510?vs=251673=265087#toc

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

2020-05-19 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I'm committing this now as-is, if something breaks, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76510/new/ https://reviews.llvm.org/D76510 ___ cfe-commits

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

2020-04-02 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added a comment. Lets highlight then that this change affects the analyzer in **frontend** mode, not in the **driver** configuration. I might make a patch for that too, btw. @NoQ, were you able to check whether **this** change could break