[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae25647d1a3: [CUDA][HIP] Add -Xarch_device and -Xarch_host options (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D76520?vs=252105&id=252311#toc

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl updated this revision to Diff 252105. yaxunl added a comment. add TODO for fixing space separated arguments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76520/new/ https://reviews.llvm.org/D76520 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/ToolCh

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a comment. In D76520#1937294 , @yaxunl wrote: > -Xarch_ does not work for passing -cc1 options in the beginning. This patch > does not change that. > > This requires some further changes about how the options after -Xarch_ are > handled. I woul

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl added a comment. In D76520#1937217 , @tra wrote: > In D76520#1936837 , @yaxunl wrote: > > > -Xarch_ works with driver options having value, e.g. > > `-fcf-protection=branch`. I added a test for that. > > > >

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a comment. In D76520#1936837 , @yaxunl wrote: > -Xarch_ works with driver options having value, e.g. > `-fcf-protection=branch`. I added a test for that. > > `-mframe-pointer=none` is a cc1 option. That's why it cannot be passed by > -Xarch_. I

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl added a comment. In D76520#1934341 , @tra wrote: > Does it handle options with values? E.g. if I want to pass > `-mframe-pointer=none` ? I vaguely recall the current -Xarch_* implementation > had some limitations. > It may be worth adding a test

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl updated this revision to Diff 252024. yaxunl added a comment. Add a test for passing options with value CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76520/new/ https://reviews.llvm.org/D76520 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/ToolChain.

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a reviewer: echristo. tra added a comment. Does it handle options with values? E.g. if I want to pass `-mframe-pointer=none` ? I vaguely recall the current -Xarch_* implementation had some limitations. It may be worth adding a test for that. CHANGES SINCE LAST ACTION https://revie

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a reviewer: jdoerfert. The argument after -Xarch_device will be added to the arguments for CUDA/HIP device compilation and will be removed for host compilation. The argument after -Xarch_host will be added to the arguments f