[PATCH] D76594: [clang][AST] User relative offsets inside AST file

2020-03-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. In D76594#1937289 , @sammccall wrote: > This looks reasonable to me, though I'm not familiar enough with the code to > do a good review. > > Just wanted to confirm my understanding: the problematic offsets that are now >

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

2020-03-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This looks reasonable to me, though I'm not familiar enough with the code to do a good review. Just wanted to confirm my understanding: the problematic offsets that are now section-relative instead of file-relative are only used in two sections of the file (macro

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

2020-03-23 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added reviewers: rsmith, dexonsmith. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Clang uses 32-bit integers for storing bit offsets from the beginning of the file that results in 512M