njames93 marked 3 inline comments as done.
njames93 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149-151
+auto CaseOptionName = (Name + "Case").str();
+auto CaseValue = Options.get(CaseOptionName, "");
+auto co
aaron.ballman added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149-151
+auto CaseOptionName = (Name + "Case").str();
+auto CaseValue = Options.get(CaseOptionName, "");
+auto const caseOptional = fromString(CaseValu
njames93 added a comment.
I'm not too sure how many other checks are like this, but I feel that this
functionality could maybe be brought out of this check and into the Options to
let more checks that take enum like configurations to use it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
njames93 created this revision.
njames93 added reviewers: aaron.ballman, alexfh.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a project: clang.
njames93 marked 2 inline comments as done.
njames93 added a project: clang-tools-extra.
njames93 added a comment.
I'm not too sure how m
njames93 marked 2 inline comments as done.
njames93 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:154
+ llvm::errs() << "warning: Invalid case style '" << CaseValue
+ << "' for readability-identifier-