[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7363ffe95f0a: [Matrix] Add draft specification for matrix support in Clang. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D76612?vs=258269=260367#toc Repository: rG LLVM

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Mark as accepted to make Phabricator/arc happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added a comment. Thanks, I plan to submit this on Monday and then make sure the patches on the clang side align with the draft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added a comment. LGTM with one very minor fix. Comment at: clang/docs/LanguageExtensions.rst:511 +*r = *a + (*b * *c); + } + fhahn wrote: > rjmccall wrote: > > This is kindof an unnecessarily unreadable example. I know you haven't > > decided

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added a comment. ping. @rjmccall & @SjoerdMeijer thanks for all the comments. I hope they are no addressed adequately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:511 +*r = *a + (*b * *c); + } + rjmccall wrote: > This is kindof an unnecessarily unreadable example. I know you haven't > decided on calling convention treatment yet, but maybe

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 258269. fhahn marked 9 inline comments as done. fhahn added a comment. Update wordings as suggested, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/LanguageExtensions.rst:511 +*r = *a + (*b * *c); + } + This is kindof an unnecessarily unreadable example. I know you haven't decided on calling convention treatment yet, but maybe the leading

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:29 +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-precision floating point +type,

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 258179. fhahn added a comment. Update wording to allow any real type for scalar -> matrix conversion and scalar,matrix binary ops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:29 +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-precision floating point +type, otherwise the program is ill-formed.

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:79 + floating point type, convert the integer or floating point operand to the + underlying element type of the operand of matrix type. + rjmccall wrote: > fhahn wrote: > > rjmccall wrote: > >

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257741. fhahn marked 3 inline comments as done. fhahn added a comment. Update list of types excluded from real types, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixTypes.rst:27 +internal layout, overall size and alignment are implementation-defined. +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:79 + floating point type, convert the integer or floating point operand to the + underlying element type of the operand of matrix type. + fhahn wrote: > rjmccall wrote: > > You should

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:27 +internal layout, overall size and alignment are implementation-defined. +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixTypes.rst:27 +internal layout, overall size and alignment are implementation-defined. +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:12 +fixed-size matrices as language values and perform arithmetic on them. + +This feature is currently experimental, and both its design and its

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257309. fhahn added a comment. Drop another instance of underlying element type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257304. fhahn added a comment. Fix typo, remove a 2 places where `underlying` element type was used, move C portion of the example to LanguageExtensions.rst, drop the rest of the example. : Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixTypes.rst:12 +fixed-size matrices as language values and perform arithmetic on them. + +This feature is currently experimental, and both its design and its Would it be good to set expectations here

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257259. fhahn marked an inline comment as done. fhahn added a comment. Rename __builtin_matrix_columnwise_{load,store} => __builtin_matrix_column_major_{load,store} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:79 + floating point type, convert the integer or floating point operand to the + underlying element type of the operand of matrix type. + rjmccall wrote: > You should standardize on one term

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257253. fhahn marked 8 inline comments as done. fhahn added a comment. Address latest comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixSupport.rst:211 + +``M __builtin_matrix_column_load(T *ptr, int row, int col, int stride)`` + fhahn wrote: > rjmccall wrote: > > This name sounds like it's loading a column, when I think you're saying

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:39 + +Future Work: Initialization syntax. + rjmccall wrote: > Maybe break the TODOs here into their own sections, which would come much > later. Done, I've moved the TODOs to a TODO section

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257115. fhahn marked 10 inline comments as done. fhahn added a comment. Address latest comments, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added a comment. Reading through the rest of the spec. Comment at: clang/docs/LanguageExtensions.rst:500 +Clang provides a matrix extension, which is currently being implemented. See +:ref:`matrixsupport` for more details. + rjmccall wrote: > This

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:3 +Matrix Support +== + rjmccall wrote: > This extension should be called something like "Matrices" or "Matrix Types". > The "X Support" name makes it sound like it's a

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257025. fhahn marked 15 inline comments as done. fhahn added a comment. Address @rjmccall comments. In D76612#1975719 , @rjmccall wrote: > Scanned through the first bit. Thanks a lot! I hope I managed to address the

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added a comment. Scanned through the first bit. Comment at: clang/docs/LanguageExtensions.rst:500 +Clang provides a matrix extension, which is currently being implemented. See +:ref:`matrixsupport` for more details. + This should include just a bit

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:254 + +Example +=== SjoerdMeijer wrote: > Hi Florian, just reading this for the first time, this is cool stuff, and > just a drive-by comment: > >

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixSupport.rst:254 + +Example +=== Hi Florian, just reading this for the first time, this is cool stuff, and just a drive-by comment: this section, Example, looks like a good candidate to be

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 255341. fhahn added a comment. Update standard conversion wording as suggested by @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 254861. fhahn added a comment. Specify that standard conversion rules do not apply to assignments for matrix types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 254505. fhahn added a comment. Update arithmetic conversion rules after recent discussion on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 252995. fhahn added a comment. Update according to comments on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/LanguageExtensions.rst

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn created this revision. fhahn added reviewers: rsmith, anemet, Bigcheese, dexonsmith. Herald added a subscriber: tschuett. Herald added a project: clang. This patch documents the planned matrix support in Clang, based on the draft specification discussed on cfe-dev in the 'Matrix Support in