[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2328305 , @rjmccall wrote: > In D76620#2328031 , @erichkeane > wrote: > >> In D76620#2328011 , @rjmccall wrote: >> >>> In

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2328031 , @erichkeane wrote: > In D76620#2328011 , @rjmccall wrote: > >> In D76620#2327988 , @erichkeane >> wrote: >> >>> In

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2328011 , @rjmccall wrote: > In D76620#2327988 , @erichkeane > wrote: > >> In D76620#2327976 , @rjmccall wrote: >> >>> In

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2327988 , @erichkeane wrote: > In D76620#2327976 , @rjmccall wrote: > >> In D76620#2327910 , @erichkeane >> wrote: >> >>> In

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327976 , @rjmccall wrote: > In D76620#2327910 , @erichkeane > wrote: > >> In D76620#2327901 , @rjmccall wrote: >> >>> You know on

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. In D76620#2327910 , @erichkeane wrote: > In D76620#2327901 , @rjmccall wrote: > >> You know on both sides that a lambda is used as a kernel, yes? Why not >> simply introduce that into

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327901 , @rjmccall wrote: > You know on both sides that a lambda is used as a kernel, yes? Why not > simply introduce that into the mangling of lambdas, so that the subset of > lambdas used as kernels form a

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. You know on both sides that a lambda is used as a kernel, yes? Why not simply introduce that into the mangling of lambdas, so that the subset of lambdas used as kernels form a stable sequence? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2327617 , @yaxunl wrote: > CUDA/HIP are facing similar issues, i.e. consistency of name mangling of > kernels between host/device compilation of the same TU. I hope this feature > to be implemented in a generic way

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

yaxunl added a comment. CUDA/HIP are facing similar issues, i.e. consistency of name mangling of kernels between host/device compilation of the same TU. I hope this feature to be implemented in a generic way so that it may be reusable for other offloading languages. Repository: rG LLVM

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2326551 , @rsmith wrote: > In D76620#2324858 , @erichkeane > wrote: > >> The feature that this supports is a part of the SYCL 2020 Provisional Spec, >> I thought that was

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rsmith added a comment. In D76620#2324858 , @erichkeane wrote: > The feature that this supports is a part of the SYCL 2020 Provisional Spec, I > thought that was sufficient. We'll look into an RFC to re-submit in the > future. Does that cover only

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

keryell added a reviewer: Ralender. keryell added a comment. Enabling this feature only with SYCL seems like an easy and quick mitigation, as SYCL compilers downstream can easily update their runtime to the new builtin name. Otherwise, just removing a feature used for almost 6 months will cause

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. Thank you. If it were SYCL-namespaced and -restricted, that would be fine, but as is it's positioned as a generic language feature. (I think we might still have had implementation/design feedback, though.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#2324119 , @rjmccall wrote: > Richard and I just found out about this commit, and we've decided to revert > it. I apologize for the very late reversion, but the reality of Clang > development is that it's very

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

rjmccall added a comment. Herald added a subscriber: yaxunl. Richard and I just found out about this commit, and we've decided to revert it. I apologize for the very late reversion, but the reality of Clang development is that it's very difficult for the code owners to watch literally every

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5a034e771d0: [SYCL] Implement __builtin_unique_stable_name. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane added a comment. In D76620#1939224 , @bader wrote: > LGTM. Thanks! Thanks! I'll give this 24 hrs for other comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76620/new/ https://reviews.llvm.org/D76620

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76620/new/ https://reviews.llvm.org/D76620 ___

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane created this revision. erichkeane added a reviewer: bader. Herald added subscribers: Anastasia, ebevhan, kristina. erichkeane added a reviewer: rolandschulz. In order to support non-user-named kernels, SYCL needs some way in the integration headers to name the kernel object themselves.