sberg added inline comments.
Comment at: clang/include/clang/AST/Expr.h:513
- /// isIntegerConstantExpr - Return true if this expression is a valid integer
- /// constant expression, and, if so, return its value in Result. If not a
- /// valid i-c-e, return false and fill i
This revision was automatically updated to reflect the committed changes.
Closed by commit rG49e5f603d400: Rename/refactor isIntegerConstantExpression to
getIntegerConstantExpression (authored by dblaikie).
Herald added a subscriber: sstefan1.
Changed prior to commit:
https://reviews.llvm.org/D
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from the formatting nits. I think this is a nice cleanup, thanks!
Comment at: clang/include/clang/AST/Expr.h:503
- /// isIntegerConstantExpr - Ret
dblaikie added a comment.
Herald added a reviewer: aaron.ballman.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76646/new/
https://reviews.llvm.org/D76646
___
cfe-commits mailing list
cfe-commits@
dblaikie added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76646/new/
https://reviews.llvm.org/D76646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
dblaikie added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76646/new/
https://reviews.llvm.org/D76646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
dblaikie created this revision.
dblaikie added a reviewer: rsmith.
Herald added subscribers: cfe-commits, jfb.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
There is a version that just tests (also called
isIntegerConstantExpression) & whereas this version is specifically used
