sammccall added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157
+resolveConflict(ArrayRef Tokens) {
+ if (Tokens.size() != 2)
+return llvm::None;
nridge wrote:
> nridge wrote:
> > sammccall wrote:
> > > why a limit of 2, vs
nridge added inline comments.
Herald added projects: clang-tools-extra, All.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157
+resolveConflict(ArrayRef Tokens) {
+ if (Tokens.size() != 2)
+return llvm::None;
nridge wrote:
> sammccall wrote:
nridge updated this revision to Diff 257596.
nridge added a comment.
Address final review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76896/new/
https://reviews.llvm.org/D76896
Files:
clang-tools-extra/clangd/FindTarget.cpp
clang-too
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd83541d1b8f7: [clangd] Color dependent names based on their
heuristic target if they have one (authored by nridge).
Changed prior to commit:
https://reviews.llvm.org/D76896?vs=257596&id=257597#toc
Repo
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:211
NonConflicting.push_back(TokRef.front());
+ else if (auto Resolved = resolveConflict
nridge added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157
+resolveConflict(ArrayRef Tokens) {
+ if (Tokens.size() != 2)
+return llvm::None;
sammccall wrote:
> why a limit of 2, vs a loop?
I'm not aware of a scenario wher
nridge updated this revision to Diff 256502.
nridge marked 7 inline comments as done.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76896/new/
https://reviews.llvm.org/D76896
Files:
clang-tools-ext
