[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rG5074776de478: [WebAssembly] Import wasm_simd128.h from Emscripten (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76959/new/

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively marked an inline comment as done. tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:30 +typedef long long __i64x2 __attribute__((__vector_size__(16), __aligned__(16))); +typedef unsigned long long __u64x2 +

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. Cool, LGTM, with optional suggestion for signed char below: Comment at: clang/lib/Headers/wasm_simd128.h:30 +typedef long long __i64x2 __attribute__((__vector_size__(16),

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively added a comment. I believe all the feedback has now been addressed. Comment at: clang/lib/Headers/wasm_simd128.h:30 +typedef long long __i64x2 __attribute__((__vector_size__(16), __aligned__(16))); +typedef unsigned long long __u64x2 +

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively updated this revision to Diff 253713. tlively added a comment. - Use header guard macro instead of pragma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76959/new/ https://reviews.llvm.org/D76959 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively updated this revision to Diff 253703. tlively marked 3 inline comments as done. tlively added a comment. - Prefix identifiers with `__` - Use specific bit-widths where possible - Do not change semantics under -funsigned-char Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

sbc100 added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:10 + +#pragma once + tlively wrote: > sunfish wrote: > > Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, > > don't use `#pragma once`? > No, I don't know.

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively marked 2 inline comments as done. tlively added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:10 + +#pragma once + sunfish wrote: > Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, don't > use `#pragma once`? No, I

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

sunfish added a comment. Very cool, thanks for putting this together! Comment at: clang/lib/Headers/wasm_simd128.h:10 + +#pragma once + Do you know why other clang headers, such as `lib/Headers/xmmintrin.h`, don't use `#pragma once`?

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively created this revision. tlively added reviewers: aheejin, sunfish. Herald added subscribers: cfe-commits, jgravelle-google, sbc100, mgorny, dschuff. Herald added a project: clang. tlively updated this revision to Diff 253249. tlively added a comment. - Update license to match xmmintrin.h

[PATCH] D76959: [WebAssembly] Import wasm_simd128.h from Emscripten

tlively updated this revision to Diff 253249. tlively added a comment. - Update license to match xmmintrin.h format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76959/new/ https://reviews.llvm.org/D76959 Files: clang/lib/Headers/CMakeLists.txt