This revision was automatically updated to reflect the committed changes.
Closed by commit rG944e322f8897: [AArch64][SVE] Add SVE intrinsics for
saturating add subtract (authored by kmclaughlin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77054/new/
https://reviews.llvm.org/D77054
___
cfe-commits mailing list
kmclaughlin updated this revision to Diff 254742.
kmclaughlin added a comment.
Moved patterns for the new intrinsics into the// sve_int_bin_cons_arit_0// and
//sve_int_arith_imm0// multiclasses
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77054/new/
https://reviews.llvm.org/D77054
efriedma added a comment.
You should be able to refactor the patterns into the definitions of the
multiclasses sve_int_bin_cons_arit_0 and sve_int_arith_imm0, to avoid repeating
them four times. (You might want to look at other places using null_frag in
SVEInstrFormats.td for inspiration.)
kmclaughlin updated this revision to Diff 254558.
kmclaughlin added a comment.
Added patterns to AArch64SVEInstrInfo.td to support llvm.[s|u]add &
llvm.[s|u]sub again, which was removed by my previous patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77054/new/
efriedma added a comment.
I can understand why you might want the new intrinsics as a temporary measure,
but I don't see the point of removing the already working support for
llvm.sadd. etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, c-rhodes, dancgr, efriedma,
cameron.mcinally.
Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya,
kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
Adds the following
