aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77194/new/
https://reviews.llvm.org/D77194
___
cfe-commits mailing list
cfe-comm
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77194/new/
https://reviews.llvm.org/D77194
___
nridge updated this revision to Diff 254712.
nridge added a comment.
Add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77194/new/
https://reviews.llvm.org/D77194
Files:
clang/test/PCH/cxx-attrs-packexpansion.cpp
clang/utils/TableGen/Clang
kadircet added a comment.
oh wow! thanks for looking into this.
Looking at the history, it seems like an oversight. The patch that introduced
packexpansion bit:
https://github.com/llvm/llvm-project/commit/44c247f0f009eec70a193335c8a353d6f8602bfd.
it didn't add that field to pchattr serializat
kadircet added a comment.
also please update the commit message to mention "PCH" rather than "serialized
ast".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77194/new/
https://reviews.llvm.org/D77194
nridge created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov.
Herald added a project: clang.
Fixes https://github.com/clangd/clangd/issues/309
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77194
Files:
clang/utils/TableGen/ClangAtt
