[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + } vitalybuka wrote: > rsmith wrote:

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + }

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + } If we're going to further extend

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka updated this revision to Diff 255016. vitalybuka added a comment. try arc diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka updated this revision to Diff 254728. vitalybuka added a comment. remove debug dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vitalybuka added a reviewer: rsmith. vitalybuka updated this revision to Diff 254728. vitalybuka added a comment. vitalybuka marked 2 inline comments as done. remove debug dump

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/bounds-checking.c:116 + // CHECK-NOT: @llvm.trap + return (s->t, s->a)[i]; + // CHECK: } C version works even without patch Repository: rG LLVM