[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d17d885283: [clangd] Parse `foo` in documentation comments and render as code. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77456?vs=255010=261063#toc Repository: rG

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall marked an inline comment as done. sammccall added a comment. Discussed offline, will follow up with fix for spaces and preserving backticks in text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77456/new/

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

kadircet added a comment. In D77456#1991484 , @sammccall wrote: > No, I'm complaining about the space before the period in > > Tests primality of `p` . > > > and the plaintext rendering too > > Tests primality of p . > Ah I see, yes this looks

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall added a comment. In D77456#1961374 , @kadircet wrote: > LGTM, thanks! > > Regarding spaces between code and text chunks, are you suggesting we should > print: > > Tests primality of`p` > No, I'm complaining about the space before the period

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

kadircet added a comment. > But I'm wondering how good an idea this is for plaintext: "Returns 'foo' on > failure" is better than "Returns foo on failure", right? (With backticks > instead of single quotes, phab is eating my formatting) ah sorry missed that one. That's actually a good point,

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Regarding spaces between code and text chunks, are you suggesting we should print: Tests primality of`p` if so, i do believe having a space before the backtick vs not

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall added a comment. Some saturday morning procrastination. But I'm wondering how good an idea this is for plaintext: "Returns 'foo' on failure" is better than "Returns foo on failure", right? (With backticks instead of single quotes, phab is eating my formatting) Maybe we should have an

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a comment. Some saturday morning procrastination. But I'm wondering how good an idea