[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

2020-04-06 Thread Raphael Isemann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGad7211df6f25 (authored by obruns, committed by teemperor). Changed prior to commit: https://reviews.llvm.org/D77468?vs=255059&id=255256#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

2020-04-06 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. Landed as ad7211df6f257e39da2e5a11b2456b4488f32a1e Btw, usually patches also need a test (especially if they are less trivial than this one). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

2020-04-06 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. We don't usually use alternative operator spelling in Clang, but otherwise this LGTM. I'll land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

2020-04-04 Thread Oliver Bruns via Phabricator via cfe-commits
obruns created this revision. obruns added reviewers: teemperor, ioeric, cfe-commits. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. Calling `back()` and `pop_back()` on the empty string is undefined behavior [1,2]. The issue manifested itself as an u