[PATCH] D77586: Allow parameter names to be elided in a function definition in C

2020-04-07 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D77586#1967052 , @erik.pilkington wrote: > > This also adds the same feature to ObjC blocks under the assumption that > > ObjC wishes to follow the C standard in this regard. > > SGTM - thats generally been the idea for

[PATCH] D77586: Allow parameter names to be elided in a function definition in C

2020-04-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. I've committed in 86b5eabfeab164dcb680f6690e7718e3d21ceeb5 Comment at:

[PATCH] D77586: Allow parameter names to be elided in a function definition in C

2020-04-07 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:278 "parameter name cannot have template arguments">; -def err_parameter_name_omitted : Error<"parameter name omitted">; +def

[PATCH] D77586: Allow parameter names to be elided in a function definition in C

2020-04-07 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. > This also adds the same feature to ObjC blocks under the assumption that ObjC > wishes to follow the C standard in this regard. SGTM - thats generally been the idea for

[PATCH] D77586: Allow parameter names to be elided in a function definition in C

2020-04-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, erik.pilkington. Herald added a subscriber: dexonsmith. WG14 has adopted N2480 (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2480.pdf) into C2x at the meetings last week, allowing parameter names of a